components/PrivyLogins/PrivyLoginsPage.tsx (2)

38-49: Add type="button" to prevent form submission behavior.

While these buttons aren't inside a form currently, explicitly setting type="button" is a defensive best practice that prevents accidental form submissions if the component is ever wrapped in a form.

🔧 Proposed fix

            <button
              key={value}
+             type="button"
              onClick={() => setPeriod(value)}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/PrivyLogins/PrivyLoginsPage.tsx` around lines 38 - 49, The
rendered period buttons in PrivyLoginsPage (the mapped <button> that calls
setPeriod(value) and checks period === value) should explicitly include
type="button" to avoid accidental form submission if this component is placed
inside a form; update the mapped button element to add type="button" alongside
the existing onClick, key, and className attributes.

---

66-70: Consider sanitizing error messages displayed to users.

Directly rendering error.message could expose internal implementation details or sensitive information from API errors. Consider using a generic message with the detailed error logged to console for debugging.

🔧 Proposed improvement

      {error && (
        <div className="rounded-md bg-red-50 p-4 text-sm text-red-700 dark:bg-red-900/20 dark:text-red-400">
-          {error instanceof Error ? error.message : "Failed to load Privy logins"}
+          Failed to load Privy logins. Please try again.
        </div>
      )}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/PrivyLogins/PrivyLoginsPage.tsx` around lines 66 - 70, The current
rendering in PrivyLoginsPage (the error conditional that shows {error instanceof
Error ? error.message : "Failed to load Privy logins"}) exposes raw error text;
change it to display a sanitized/generic message (e.g., "Failed to load Privy
logins. Please try again.") and move detailed information to logs for debugging
by calling console.error(error) or a logger when error is present. Optionally
implement a small helper like sanitizeErrorMessage or map known error types to
user-friendly strings and use that helper in the error render path, while
ensuring the original error object is still logged for developers.

types/privy.ts (1)

9-13: Consider a discriminated union for error handling.

The status field can be "error", but the type still requires total and logins fields. A discriminated union would provide better type safety when handling error responses:

type PrivyLoginsSuccessResponse = {
  status: "success";
  total: number;
  logins: PrivyLoginRow[];
};

type PrivyLoginsErrorResponse = {
  status: "error";
  error: string;
};

export type PrivyLoginsResponse = PrivyLoginsSuccessResponse | PrivyLoginsErrorResponse;

This is optional if the API always throws on errors before returning a response body with status: "error".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@types/privy.ts` around lines 9 - 13, Replace the current flat
PrivyLoginsResponse type with a discriminated union so callers can statically
handle success vs error cases: define PrivyLoginsSuccessResponse (status:
"success", total: number, logins: PrivyLoginRow[]) and PrivyLoginsErrorResponse
(status: "error", error: string) and export PrivyLoginsResponse =
PrivyLoginsSuccessResponse | PrivyLoginsErrorResponse; update any places that
assume total/logins exist to narrow on status first.

components/PrivyLogins/PrivyLoginsTable.tsx (1)

33-34: Date formatting is locale-dependent.

toLocaleString() without arguments produces output based on the user's browser locale, which may be inconsistent across admin users. Consider using a specific locale or a date formatting library for consistent display.

🔧 Optional: Use explicit locale

-                {new Date(login.created_at).toLocaleString()}
+                {new Date(login.created_at).toLocaleString("en-US", {
+                  dateStyle: "medium",
+                  timeStyle: "short",
+                })}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/PrivyLogins/PrivyLoginsTable.tsx` around lines 33 - 34, The
TableCell is rendering dates with new Date(login.created_at).toLocaleString(),
which yields locale-dependent output; update the rendering in the
PrivyLoginsTable component so the date is formatted consistently (either by
using Intl.DateTimeFormat with an explicit locale/format options or a date
library like date-fns/format) when displaying login.created_at inside the
TableCell; locate the JSX that references login.created_at and replace the
toLocaleString() call with a deterministic formatter (or a small helper
function) so all admin users see a consistent date/time format.